Remove enable_default_view option from sdk MeterProvider
#2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
2546-remove-default-view
branch
5 times, most recently
from
7745b9c to
ffaf815
Compare
aabmass
force-pushed
the
2546-remove-default-view
branch
from
ffaf815 to
f1112e3
Compare
aabmass
force-pushed
the
2546-remove-default-view
branch
from
f1112e3 to
a493ab7
Compare
srikanthccv
approved these changes
Mar 25, 2022
aabmass
commented
Mar 25, 2022
lzchen
approved these changes
Mar 25, 2022
ocelotl
approved these changes
Mar 25, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/metric_reader_storage.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2546. Also updated the docs and explained what the spec suggests.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added integration test
Does This PR Require a Contrib Repo Change?
Checklist: